Reduce unnecessary helper calls #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the Merbridge OpenSource Community!👏 We're delighted to have you onboard 💘 |
dddddai
commented
Aug 26, 2022
| @@ -141,7 +141,7 @@ func (s *server) buildListener(netns string) error { | |||
| var addrs []net.Addr | |||
| ifaces, _ := net.Interfaces() | |||
| for _, iface := range ifaces { | |||
| if iface.Name == "lo" { | |||
| if (iface.Flags&net.FlagLoopback) != 0 || (iface.Flags&net.FlagUp) == 0 { | |||
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage 40.33% 40.33%
=======================================
Files 7 7
Lines 419 419
=======================================
Hits 169 169
Misses 236 236
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kebe7jun
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.