Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition #88

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Fix race condition #88

merged 3 commits into from
Jan 16, 2024

Conversation

goccy
Copy link
Member

@goccy goccy commented Jan 15, 2024

This comment has been minimized.

@goccy goccy requested a review from shuheiktgw January 15, 2024 09:49
Copy link

Code Metrics Report

main (0210289) #88 (2753024) +/-
Coverage 64.4% 64.4% -0.0%
Code to Test Ratio 1:0.5 1:0.5 -0.0
Test Execution Time 3m25s 3m25s 0s
Details
  |                     | main (0210289) | #88 (2753024) |  +/-  |
  |---------------------|----------------|---------------|-------|
- | Coverage            |          64.4% |         64.4% | -0.0% |
  |   Files             |             61 |            61 |     0 |
  |   Lines             |           8832 |          8833 |    +1 |
  |   Covered           |           5686 |          5686 |     0 |
- | Code to Test Ratio  |          1:0.5 |         1:0.5 |  -0.0 |
  |   Code              |          24633 |         24634 |    +1 |
  |   Test              |          11168 |         11168 |     0 |
  | Test Execution Time |          3m25s |         3m25s |    0s |

Code coverage of files in pull request scope (0.0% → 0.0%)

Files Coverage +/-
grpc/federation/cel.go 0.0% 0.0%

Reported by octocov

Copy link
Contributor

@shuheiktgw shuheiktgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️

@goccy goccy merged commit 879a6bd into main Jan 16, 2024
4 checks passed
@goccy goccy deleted the fix-race-condition branch January 16, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants