Enable the ContextualLibrary #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuheiktgw
commented
Jan 23, 2024
| @@ -35,7 +38,7 @@ func IsStandardLibraryType(typeName string) bool { | |||
| } | |||
|
|
|||
| func (lib *Library) LibraryName() string { | |||
| return "grpc.federation" | |||
| return lib.name | |||
There was a problem hiding this comment.
I've noticed that we cannot use the same library name between the static and contextual libraries since the libraries are singleton and hence immutable.
I've circumvented the problem by using the different names between the two. Another option may be to stop using the SingletonLibrary interface, but what do you think? 🤔
There was a problem hiding this comment.
The library name does not affect the gRPC Federation's user, so I think this is good 👍
Code Metrics Report
Details | | main (203b2fe) | #92 (df31dbf) | +/- |
|---------------------|----------------|---------------|-------|
- | Coverage | 64.4% | 64.4% | -0.0% |
| Files | 62 | 62 | 0 |
| Lines | 8848 | 8851 | +3 |
+ | Covered | 5700 | 5701 | +1 |
- | Code to Test Ratio | 1:0.5 | 1:0.5 | -0.0 |
| Code | 24692 | 24701 | +9 |
+ | Test | 11255 | 11258 | +3 |
+ | Test Execution Time | 3m33s | 3m23s | -10s |Code coverage of files in pull request scope (77.6% → 77.6%)
Reported by octocov |
goccy
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled the ContextualLibrary I've added in #89.