Vulcan 650/expanded cell renderer #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brahmprakashMishra
requested changes
Apr 29, 2024
| @@ -257,7 +257,7 @@ function RenderArray(value) { | |||
| return mapped; | |||
| } | |||
|
|
|||
| function RenderString(value) { | |||
| export function RenderString(value) { | |||
| const str = value?.toString() || ''; | |||
| if (str.startsWith('http') || str.startsWith('https')) { | |||
| return ( | |||
There was a problem hiding this comment.
- Test cases / coverage addition is missing for added functionality
- PR to neodash is missing against this functionality (there is already an expandGridRenderer is opened, maybe we can update that). This will need finishing the contribute training.
brahmprakashMishra
approved these changes
May 6, 2024
brahmprakashMishra
added a commit
that referenced
this pull request
May 8, 2024
Revert "Merge pull request #114 from mercedes-benz/VULCAN-650/Expande…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.