- resolved unused import in write_pdx_file.py #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. making the overall codebase less memory consuming and the code more clean.
|
DO NOTE: Contributors License Agreement has been signed and send... however... mentioned address was incorrect and mail bounced back. Please advice. |
|
I have my doubts about whether this improves anything, but I also cannot see how it could make things worse, so let's merge. Welcome to the odxtools contributors @louwersj! |
|
@andlaus I think I just very much like clean code... and in theory it should save a tiny bit of memory allocation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed two import lines from write_pdx_file.py as they are not used. making the overall codebase less memory consuming and the code more clean.
DO NOTE: Contributors License Agreement is in progress and I will send it in a bit. Will notify as part of this pull request when that is done.