Untangle Diaglayer (1 of X) #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
all caps names signify values, and this is a type. (types ought to use CamelCase...) Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
it used to be co-located with DiagLayer... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
kayoub5
reviewed
May 30, 2023
examples/somersaultecu.py
Outdated
| odx_id=OdxLinkId("somersault_lazy", doc_frags), | ||
| short_name="somersault_lazy", | ||
| long_name="Somersault lazy ECU", | ||
| description="<p>Sloppy variant of the somersault ECU (lazy < assiduous)</p>", | ||
| parent_refs=[ | ||
| DiagLayer.ParentRef( # <- TODO: this is a bit sketchy IMO | ||
| ParentRef( # <- TODO: this is a bit sketchy IMO |
There was a problem hiding this comment.
not really. I removed it, thanks.
kayoub5
reviewed
May 30, 2023
kayoub5
reviewed
May 30, 2023
thanks to [at]kayoub5. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
kayoub5
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks the start a small quest of mine to untangle the code spaghetti that is currently located in
diaglayer.py. This PR moves theParentRefandDiagLayerContainerclasses into their separate files, renames theDIAG_LAYER_TYPEenum toDiagLayerTypeand fixes a small copy-and-pasto in the writing code for communication parameters.Since all patches are self-contained and simple but some are fairly big, I recommend reviewing this PR by looking at the individual commits instead of the aggregate changes of the whole PR.
Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information