Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiagLayer: refactor the value inheritance mechanism #146

Merged
merged 4 commits into from
Jun 21, 2023

Commits on Jun 20, 2023

  1. DiagLayer: refactor the value inheritance mechanism

    with this, all objects that the spec says shall be subject to the
    value inheritance mechanism should now covered (modulo bugs), and the
    mechanism is IMO implemented in a more straight forward way with less
    code duplication...
    
    Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
    Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
    andlaus committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4c7d986 View commit details
    Browse the repository at this point in the history
  2. DiagLayer: clarify comment

    thanks to [at]kayoub5 for bringing this up.
    
    Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
    Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
    andlaus committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    6e9ce25 View commit details
    Browse the repository at this point in the history
  3. make mypy 1.4.0 happy

    seems like it was released today and produced one new error...
    
    Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
    Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
    andlaus committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    6de1fc4 View commit details
    Browse the repository at this point in the history
  4. add a few clarifying comments about inherited objects that are not su…

    …bject to value inheritance
    
    thanks to [at]kayoub5 for the proposal.
    
    Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
    Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
    andlaus committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8400304 View commit details
    Browse the repository at this point in the history