Add PositionableParam
#278
Conversation
|
I simply do not see the benefit of this PR, if non-positioned parameters simply don't exist, why introduce the complexity of a non-necessary abstraction layer? |
mainly to make it easier to look at the XSD and find the corresponding odxtools code. But I agree, we should probably solve this "by documentation" (i.e., add a comment that |
A documentation change should be more than enough |
the `Parameter` class corresponds to the `POSITIONABLE-PARAM` type of the ODX specification, not to `PARAM`. This is because the specification does not define any non-positionable parameters. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io>
andlaus
force-pushed
the
positionable_param
branch
from
30d3bdb
to
f1e14d5
Compare
|
okay. I moved all the "meat" of this PR into |
andlaus
force-pushed
the
positionable_param
branch
2 times, most recently
from
a05a388
to
43a13ef
Compare
this avoids mistakes and simplifies the code. unfortunately, the "leaf" parameter classes must do their decoding using the `_decode_positioned_from_pdu()` method instead of `decode_from_pdu()`. To avoid mistakes, I've marked `Parameter.decode_from_pdu()` method as `@final` so that type checkers can complain if it is overridden. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io>
andlaus
force-pushed
the
positionable_param
branch
from
43a13ef
to
a5ebc2d
Compare
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io>
| the next byte position after the extracted parameter | ||
| """ | ||
| pass | ||
| def _decode_positioned_from_pdu(self, decode_state: DecodeState) -> ParameterValue: |
There was a problem hiding this comment.
Maybe use @abstractmethod?
There was a problem hiding this comment.
foreshadowing: abstract base classes prevent using the from_et() pattern for class hierarchies because for this pattern, base classes must be instantiated in the .from_et() constructor of child classes...
This is the base class of all parameters for which a position within the PDU can be defined. Interestingly, the XSD does not seem to feature any parameters that are not positionable, but let's reflect the class hierarchy implied by the ODX specification...
Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information