fix: COMPU-DEFAULT-VALUE parsing issue by modifying its hierarchical … #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
looks good, let's merge. (I'll make a point release...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During my usage of this tool, I encountered an issue where the
COMPU-DEFAULT-VALUEwithin myCOMPU-METHODwas always returned as None, despite the presence ofCOMPU-DEFAULT-VALUEentries in my ODX files. Upon inspecting the code, I discovered that the hierarchical level ofCOMPU-DEFAULT-VALUEwas incorrectly placed underCOMPU-METHOD. However, according to the actual structure,COMPU-DEFAULT-VALUEshould be located underCOMPU-INTERNAL-TO-PHYS.I proceeded to adjust the hierarchical level of the element accordingly, and after this modification, the
COMPU-DEFAULT-VALUEwas successfully parsed. This fix addresses a parsing issue and ensures thatCOMPU-DEFAULT-VALUEis correctly interpreted from the ODX files, adhering to the expected structure.I hope this modification can be reviewed and integrated to improve the tool's reliability and usefulness for all users facing similar issues.
Thank you for considering this pull request.