Implement the IMPORT-REF mechanism #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayoub5
reviewed
Apr 5, 2024
kayoub5
reviewed
Apr 5, 2024
If I understood the spec correctly, this simply extends the pool of objects that are locally referenceable via ODXLINK (i.e., without having to specify the DOCREF attribute), and can thus be seen as a kind of "poor man's inheritance" mechanism. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
once more, thanks to [at]kayoub5 for the catches! Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
kayoub5
approved these changes
Apr 6, 2024
|
okay. Even though it seems like the issues @QWander experiences are not caused by the IMPORT-REFS mechnism, there is a decent chance that this patch works as advertised. Let's merge and fix the fallout (if any) later... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understood the spec correctly, this simply extends the pool of objects that are locally referenceable via ODXLINK (i.e., without having to explicitly specify the DOCREF attribute in the reference), and can thus be seen as a kind of "poor man's inheritance" mechanism.
Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information