Improve the file loading mechansims #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this refactors the file loading mechanism with the goal to create a database from multiple constituive files. It works by introducing a new user facing `odxtools.load_files(filename1, filename2, ...)` function. Besides this, `odxtools.load_directory(dirname)` is added. This function loads all files contained in a directory into a single database. The main application is probably to directly load an unzipped PDX file. This is a quite convenient feature when developing tools or a dataset. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Florian Jost <florian.jost@mbition.io>
kayoub5
reviewed
May 24, 2024
kayoub5
reviewed
May 24, 2024
kayoub5
reviewed
May 24, 2024
thanks to [at]kayoub5 for the suggestion! Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Florian Jost <florian.jost@mbition.io>
kayoub5
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the file loading mechanism with the goal to be able to create databases from multiple constitutive files. It works by introducing a new user facing
odxtools.load_files(filename1, filename2, ...)function.Besides this,
odxtools.load_directory(dirname)is added. This function loads all files contained in a directory into a single database. The main application is probably to directly load an unzipped PDX file. This is a quite convenient feature when developing tools or a dataset.Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information