Skip to content

Commit

Permalink
Change max project length size to 150 #3102
Browse files Browse the repository at this point in the history
- reason for this change is the maximum filename length on OS
- The project id will be part of the report filename
  • Loading branch information
winzj committed May 23, 2024
1 parent 99d4027 commit 0d918f2
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 22 deletions.
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
-- SPDX-License-Identifier: MIT

-- Update project id : we now accept 255 characters see ProjectIdValidation
ALTER TABLE adm_project ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE scan_report ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE scan_access ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE schedule_access ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE schedule_project_whitelist ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE schedule_sechub_job ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE scan_project_log ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE adm_job_information ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE scan_product_result ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE scan_project_config ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE adm_project_metadata ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE schedule_project_config ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE statistic_job ALTER COLUMN project_id TYPE varchar(255);
ALTER TABLE statistic_job_run ALTER COLUMN project_id TYPE varchar(255);
-- Update project id : we now accept 150 characters see ProjectIdValidation
ALTER TABLE adm_project ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE scan_report ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE scan_access ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE schedule_access ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE schedule_project_whitelist ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE schedule_sechub_job ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE scan_project_log ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE adm_job_information ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE scan_product_result ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE scan_project_config ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE adm_project_metadata ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE schedule_project_config ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE statistic_job ALTER COLUMN project_id TYPE varchar(150);
ALTER TABLE statistic_job_run ALTER COLUMN project_id TYPE varchar(150);

ALTER TABLE adm_project_whitelist_uri ALTER COLUMN project_project_id TYPE varchar(255);
ALTER TABLE adm_project_whitelist_uri ALTER COLUMN project_project_id TYPE varchar(150);

ALTER TABLE adm_project_to_user ALTER COLUMN projects_project_id TYPE varchar(255);
ALTER TABLE scan_execution_profile_to_project ALTER COLUMN projects_project_id TYPE varchar(255);
ALTER TABLE adm_project_to_user ALTER COLUMN projects_project_id TYPE varchar(150);
ALTER TABLE scan_execution_profile_to_project ALTER COLUMN projects_project_id TYPE varchar(150);
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
public class ProjectIdValidationImpl extends AbstractSimpleStringValidation implements ProjectIdValidation {

public static final int PROJECTID_LENGTH_MIN = 2;
public static final int PROJECTID_LENGTH_MAX = 255;
public static final int PROJECTID_LENGTH_MAX = 150;

@Override
protected void setup(ValidationConfig config) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ public class ProjectIdValidationImplTest {

private ProjectIdValidationImpl validationToTest = new ProjectIdValidationImpl();

private static final String VALID_PROJECT_ID_WITH_255_CHARS = "a0123456789b0123456789c0123456789d0123456789e0123456789f0123456789g0123456789h0123456789i0123456789j0123456789k0123456789l0123456789m0123456789n0123456789o0123456789p0123456789q0123456789r0123456789s0123456789t0123456789u0123456789v0123456789w0123456789yz";
private static final String VALID_PROJECT_ID_WITH_150_CHARS = "012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789";

@ParameterizedTest
@ValueSource(strings = { "a2", "i-am-with-hyphens", "i_am_with_underscore", VALID_PROJECT_ID_WITH_255_CHARS })
@ValueSource(strings = { "a2", "i-am-with-hyphens", "i_am_with_underscore", VALID_PROJECT_ID_WITH_150_CHARS })
void valid_projectIds(String projectId) {
/* execute */
ValidationResult validationResult = validationToTest.validate(projectId);
Expand All @@ -30,7 +30,7 @@ void valid_projectIds(String projectId) {
@NullSource
@EmptySource
@ValueSource(strings = { "a", "i.am.with.dot", "i-am/slashy", "with\\backslash", "percent%", "dollar$", "question?", "colon:", "exclamationmark!",
VALID_PROJECT_ID_WITH_255_CHARS + "x" })
VALID_PROJECT_ID_WITH_150_CHARS + "x" })
void invalid_projectIds(String projectId) {
/* execute */
ValidationResult validationResult = validationToTest.validate(projectId);
Expand Down

0 comments on commit 0d918f2

Please sign in to comment.