Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable / Disable scheduler job processing + provide Scheduler Status #12

Closed
de-jcup opened this issue Aug 1, 2019 · 2 comments
Closed
Assignees
Labels

Comments

@de-jcup
Copy link
Member

de-jcup commented Aug 1, 2019

At the moment a deployment in cluster environment - e.g. kubernetes - has got following problem:

When we a upgrade deployed server versions to next version, the running server instances will be stopped.... so also the JVMs... means also every running SecHub Job inside... After the new deployments these jobs are lost.

The easiest way to handle this, is to integrate a switch option into sechub administration and sechub scheduler.

Usecases:

  • Admin stops scheduling
  • Admin restarts scheduling
  • Admin gets information about scheduling status (stopped,running, amount of waiting scheduled Jobs)

When sheduling is enabled/disabled a notification to admins shall be sent, so it's clear what happend (when disabled no job processing happens...)

@de-jcup de-jcup changed the title Stop / Restart scheduler and Overview Stop / restart scheduler and overview Aug 1, 2019
@de-jcup de-jcup added this to the 1.1.0 milestone Aug 26, 2019
@de-jcup de-jcup self-assigned this Sep 9, 2019
de-jcup added a commit that referenced this issue Sep 10, 2019
- refactoring:
  removed static field OBJECT from all Jsonables, because this
  leads to misunderstanding - and wrong usage. Now parts using
  OBJECT.from(...) must use their own field for this.

- added services, rest controller
- added database tables

On behalf of Daimler TSS GmbH.
@de-jcup de-jcup changed the title Stop / restart scheduler and overview Enable / Disable scheduler job processing + provide Scheduler Status Sep 11, 2019
de-jcup added a commit that referenced this issue Sep 11, 2019
- update documentation about architecture risk and technical debts
  and linked issue here.
- renamed Start/Stop parts to more dedicated names - e.g.
  EnableScheduleJobProcessing
- sending and handling missing events/messages
- added integration test for schedule job processing disable/enable
- renamed former named class SchedulerConfig to
  SchedulingEnabledByConditionConfiguration because no longer name
  conflict with new config in db

On behalf of Daimler TSS GmbH.
de-jcup added a commit that referenced this issue Sep 11, 2019
- Some bugfixes
- Added actions to developer admin UI
- works now

On behalf of Daimler TSS GmbH.
@de-jcup
Copy link
Member Author

de-jcup commented Sep 12, 2019

We provide here now a common way for getting status information in administration - not only for scheduling but also for any other kind of status information. One start entry point: StatusAdministrationRestController

de-jcup added a commit that referenced this issue Sep 12, 2019
@de-jcup
Copy link
Member Author

de-jcup commented Sep 12, 2019

Found SecHubAdministrationEnvironment problematic, will rename SecHubServerEnvironment to SecHubEnvironment and make available in shared kernel.

Reason: We need the information about sechub server address very often and we have currently no email / notification where we use a special administration url. If we need this we should provide the administration url also inside SecHubEnvironment! Having multiple pods we can add the information inside kubernetes deployments as well in future!

de-jcup added a commit that referenced this issue Sep 12, 2019
- add notifications about disable/enable job processing on scheduler
- add notification tests into integration test
- moved SecHubEnvironment to shared kernel so available everywhere
- dropped SecHubAdministrationEnvironment and replaced by
  SecHubEnvironment, because currently we have no need for a
  special application
- fixed StatusAdministrationRestControllerRestDocTest

On behalf of Daimler TSS GmbH.
@de-jcup de-jcup closed this as completed Sep 12, 2019
de-jcup referenced this issue in de-jcup/sechub Oct 17, 2019
- refactoring:
  removed static field OBJECT from all Jsonables, because this
  leads to misunderstanding - and wrong usage. Now parts using
  OBJECT.from(...) must use their own field for this.

- added services, rest controller
- added database tables

On behalf of Daimler TSS GmbH.
de-jcup referenced this issue in de-jcup/sechub Oct 17, 2019
- update documentation about architecture risk and technical debts
  and linked issue here.
- renamed Start/Stop parts to more dedicated names - e.g.
  EnableScheduleJobProcessing
- sending and handling missing events/messages
- added integration test for schedule job processing disable/enable
- renamed former named class SchedulerConfig to
  SchedulingEnabledByConditionConfiguration because no longer name
  conflict with new config in db

On behalf of Daimler TSS GmbH.
de-jcup referenced this issue in de-jcup/sechub Oct 17, 2019
- Some bugfixes
- Added actions to developer admin UI
- works now

On behalf of Daimler TSS GmbH.
de-jcup referenced this issue in de-jcup/sechub Oct 17, 2019
de-jcup referenced this issue in de-jcup/sechub Oct 17, 2019
- add notifications about disable/enable job processing on scheduler
- add notification tests into integration test
- moved SecHubEnvironment to shared kernel so available everywhere
- dropped SecHubAdministrationEnvironment and replaced by
  SecHubEnvironment, because currently we have no need for a
  special application
- fixed StatusAdministrationRestControllerRestDocTest

On behalf of Daimler TSS GmbH.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant