-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapping configuration concept #129
Comments
With a look at #2 we must handle this carefully and consider configuration in big picture. When having a web UI (#11 ) we need REST operations able to to handle actions like in next mockup: Because we create an own backend application for #11 we are not forced to handle each operation as necessary for mock ui - but it's okay to make REST calls not too different/difficult... Domain: Administration
Domain: Scan
Shared kernel:
|
Developer admin UITo provide this as simple as possible inside developer admin UI, we will provide
|
- providing db entities, validation, service and rest - added integration tests
We let administrators add also additional mappings (custom identifiers) no restrictions at the moment. |
- added integration test: changes in administration domain trigger changes in scan domain as well and scan will use triggered mappings. - integrated messaging for mappings - updated coding conventions ("transactional" services) - storing scan config into db - scan domain does now have a periodical refresh check for scan configuration updates (so db synchronizes cluster) - changed integration test parts - dropped former initial config parts - restdoc documenation added
- mapping identifier does now provide - self sanity check (duplicates, valid id) - mapping type - scan domain does only accept global or adapter configuration mapping types now
- CSV import/export for mappings - Try as ScanConfig added (needed dependency to sechub-scan inside sechub-developertools) so admin is able to test mapping results
- providing db entities, validation, service and rest - added integration tests
- added integration test: changes in administration domain trigger changes in scan domain as well and scan will use triggered mappings. - integrated messaging for mappings - updated coding conventions ("transactional" services) - storing scan config into db - scan domain does now have a periodical refresh check for scan configuration updates (so db synchronizes cluster) - changed integration test parts - dropped former initial config parts - restdoc documenation added
- mapping identifier does now provide - self sanity check (duplicates, valid id) - mapping type - scan domain does only accept global or adapter configuration mapping types now
- CSV import/export for mappings - Try as ScanConfig added (needed dependency to sechub-scan inside sechub-developertools) so admin is able to test mapping results
- Dropped integration test rest controller method for direct refresh of scan config (we just wait for periodic update!) - integration test does now check every second for scan config refresh - switched log statement to trace when same configuration detected - changed integration tests so no waiting for scan config refresh - added missing service annotation
Usecase
As an administrator I want to change my ScanConfig by a rest call at administration domain. All running instances of sechub shall be synched and use this configuration
Situation
With #127 we introduced a way to configure scan behavours.
This was done by
@Value
injection. This is okay as first attempt, but we need to restart server to have changes.Also we got restrictions about configuration sizes (e.g. on Linux 128KB, see https://unix.stackexchange.com/questions/336934/raise-128kib-limit-on-environment-variables-in-linux )
Wanted solution
NOT ACCEPTABLE
The text was updated successfully, but these errors were encountered: