Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecHub report results do not contain job UUID #864

Closed
de-jcup opened this issue Oct 29, 2021 · 0 comments
Closed

SecHub report results do not contain job UUID #864

de-jcup opened this issue Oct 29, 2021 · 0 comments
Assignees
Labels
bug Something isn't working critical report
Milestone

Comments

@de-jcup
Copy link
Member

de-jcup commented Oct 29, 2021

Situation

With release v0.27.0-server the reports did not conain a job uuid any longer.
This is critical for sechub client interactive false-positive handling were the Job UUID of an report is used - and will fail because not existing.

Wanted

When user fetches reports the Job UUID must be in report again

Solution

Problem lays inside SerecoProductResultTransformer.java where after the refactoring the job UUID was not set.
This must be fixed.
Also ScanSecHubReport shall have an fallback for reports that were currently already transformed without job uuid inside.

@de-jcup de-jcup added this to the Server 0.27.1 milestone Oct 29, 2021
@de-jcup de-jcup self-assigned this Oct 29, 2021
@de-jcup de-jcup added bug Something isn't working report labels Oct 29, 2021
de-jcup added a commit that referenced this issue Oct 29, 2021
- changed sereco product result transformer - does now
  set job uuid into reporting model (was missing)
- changed existing pds integration test and check now for job uuid
  inside
- added unit tests to check fallback handling
- implemented fallback handling when no Job UUID in report JSON result
  (so old reports having no report job uuid inside will be
  repaired automatically)
@de-jcup de-jcup closed this as completed Oct 29, 2021
de-jcup added a commit that referenced this issue Oct 29, 2021
Fix missing job uuid in report, closes #864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical report
Projects
None yet
Development

No branches or pull requests

1 participant