Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapper OWASP ZAP can read rules to deactivate from env variable #1452 #1455

Merged
merged 8 commits into from
Jul 15, 2022
Merged

Wrapper OWASP ZAP can read rules to deactivate from env variable #1452 #1455

merged 8 commits into from
Jul 15, 2022

Conversation

winzj
Copy link
Member

@winzj winzj commented Jul 5, 2022 •
edited
Loading

winzj added 6 commits July 5, 2022 12:58
@winzj
Wrapper OWASP ZAP can read rules to deactivate from env variable #1452
99799db 
- wrapper can read rule references to deactivate from env variable
  ZAP_DEACTIVATED_RULE_REFERENCES
- added documentation on how to use this new feature
- added default full ruleset file, with all rules in
  release status: release
- added test cases
@winzj
Make test easier to read #1452
89ffd03
@winzj
Fix typo #1452
f6ba45d
@winzj
Removed duplicate from previous test #1452
3f9ac16
@winzj
Improved test #1452
2de57d3
@winzj
Spotless apply #1452
bbefc51
@winzj winzj marked this pull request as ready for review July 13, 2022 07:21
@winzj winzj requested a review from de-jcup July 13, 2022 07:21
@winzj winzj assigned de-jcup and unassigned de-jcup Jul 13, 2022
@winzj winzj marked this pull request as draft July 13, 2022 10:51
@winzj
Implemented option to deactivate scan rules via command line #1452
ca4a3a3 
- implemented command line parameter to deactivate scan rules via
  command line
- Restructured OwaspZapScanConfigurationFactory to always add the rules
  from --rulesDeactivationfile to the deactivated rules
- added tests and changed OwaspZapScanConfigurationFactoryTest
@winzj winzj requested review from Jeeppler and removed request for de-jcup July 13, 2022 16:34
@winzj winzj marked this pull request as ready for review July 13, 2022 16:35
Jeeppler
Jeeppler suggested changes Jul 13, 2022
View reviewed changes
Copy link
Member

@Jeeppler Jeeppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

...owasp-zap/src/main/java/com/mercedesbenz/sechub/owaspzapwrapper/cli/CommandLineSettings.java Outdated Show resolved Hide resolved
...apper-owasp-zap/src/main/java/com/mercedesbenz/sechub/owaspzapwrapper/scan/AbstractScan.java Outdated Show resolved Hide resolved
@winzj winzj requested a review from Jeeppler July 14, 2022 15:14
Jeeppler
Jeeppler approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@Jeeppler Jeeppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯 . Merge it.

In addition, please have a look at the single comment I left.

...apper-owasp-zap/src/main/java/com/mercedesbenz/sechub/owaspzapwrapper/scan/AbstractScan.java Show resolved Hide resolved
@winzj winzj mentioned this pull request Jul 15, 2022
Closed
@winzj winzj merged commit c440417 into develop Jul 15, 2022
@winzj winzj deleted the feature-1452-wrapper-rule-references-to-deactivate-env-variable branch July 15, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeeppler Jeeppler Jeeppler approved these changes

Assignees

@Jeeppler Jeeppler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrapper OWASP ZAP should be able to read rule references to deactivate from ENV variable (comma separated)
3 participants
@winzj @Jeeppler @de-jcup