Improve PDS auto ZIP/TAR handling #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduced 'pds.config.supported.datatypes' as job parameter - introduced NONE in SecHubDataConfigurationType - introduced SecHUbDataConfigurationTypeListParser - introduced configuration autofix on PDS start - added tests - changed integration test setup - fixed typos - renamed some methods
de-jcup
force-pushed
the
feature-1172-possibility-to-define-supported-pds-upload-types
branch
from
cbe8dd0
to
ae89d2a
Compare
feature-1172-possibility-to-define-supported-pds-upload-types
- removed "extractUploads" from code and examples - added new key "pds.config.supported.datatype" into example one time with description, another without (so clear its optional) - added testcase to ensure example configuration file can be still loaded
de-jcup
force-pushed
the
feature-1172-possibility-to-define-supported-pds-upload-types
branch
from
f924e4f
to
ce05a9d
Compare
- separated parts from PDSWorkspaceService into own classes: more readable, better testable - added unit tests - added javadoc - changed code, so PDS workspace service gathers information, download only necessary stuff and checks for extraction output - Workspace preparation result calculator does the final step and provides information if script can be launched or not - adopted existing unit tests to work with the new dependencies - added integration tests - enhanced test scenario 17
de-jcup
force-pushed
the
feature-1172-possibility-to-define-supported-pds-upload-types
branch
from
ce05a9d
to
cfadb6d
Compare
- many existing integration tests did fail, because the PDS standard code scan integration test setup did now insist on sources - removed this setup (so accepting binary,source and also none). This fixed the problem - scenario 17 integration tests do still check the correct behavior for the supported data types
winzj
requested changes
Nov 28, 2022
sechub-doc/src/docs/asciidoc/documents/pds/product_delegation_server_config_example1.json
Outdated
Show resolved
Hide resolved
sechub-doc/src/docs/asciidoc/documents/pds/product_delegation_server_config_example1.json
Outdated
Show resolved
Hide resolved
- added unit test for problem found in PR - changed example configuration
de-jcup
deleted the
feature-1172-possibility-to-define-supported-pds-upload-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR