Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation build by providing correct fallback objects #3257 #3258

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

de-jcup
Copy link
Member

@de-jcup de-jcup commented Jun 28, 2024

- problem was that the fallback objects used at asciidoc generation,
  did not contain non-nullable values
- wrote unit test to check that this fails in normal build as well
  (fail early)
- UNDEFINED values are now not only set by spring container, but
  also set as default when used as POJO
@de-jcup de-jcup force-pushed the feature-3257-fix-failing-documentation-build branch from 2696b56 to 8f39d84 Compare June 28, 2024 10:45
@de-jcup de-jcup requested a review from winzj June 28, 2024 10:46
@de-jcup de-jcup marked this pull request as ready for review June 28, 2024 10:47
Copy link
Member

@winzj winzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@de-jcup de-jcup merged commit 99783a6 into develop Jul 1, 2024
2 checks passed
@de-jcup de-jcup deleted the feature-3257-fix-failing-documentation-build branch July 1, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asciidoc generation fails
2 participants