Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify json_name to camel case for Python entities #667

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Unify json_name to camel case for Python entities #667

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
810a5a2
refactor: unify json_name to camel case in email_a
sweep-from-cheng[bot] Sep 20, 2023
c6862c5
fix: Update json_name attribute in quote_items.py
sweep-from-cheng[bot] Sep 20, 2023
a568657
fix: Update json_name attribute in product_comment
sweep-from-cheng[bot] Sep 20, 2023
a8f3898
fix: Update json_name attribute in production_comm
sweep-from-cheng[bot] Sep 20, 2023
14b53a2
fix: Update json_name attribute in job_comments.py
sweep-from-cheng[bot] Sep 20, 2023
2449a07
fix: Remove unnecessary file python/product_commen
sweep-from-cheng[bot] Sep 20, 2023
236e8d4
Delete python/product_comments.py
s3341458 Sep 20, 2023
9f24d44
fix: Correct json_name attribute for QuoteItem cla
sweep-from-cheng[bot] Sep 20, 2023
89224e5
Merge main into sweep/unify-json-name-camel-case
sweep-from-cheng[bot] Oct 4, 2023
0f19d36
Merge main into sweep/unify-json-name-camel-case
sweep-from-cheng[bot] Oct 4, 2023
e38648e
Merge main into sweep/unify-json-name-camel-case
sweep-from-cheng[bot] Oct 13, 2023
3a143e2
Merge main into sweep/unify-json-name-camel-case
sweep-from-cheng[bot] Oct 18, 2023
e9127aa
Merge main into sweep/unify-json-name-camel-case
sweep-from-cheng[bot] Oct 22, 2023
e7572aa
Merge main into sweep/unify-json-name-camel-case
sweep-from-cheng[bot] Oct 27, 2023
8762499
Merge main into sweep/unify-json-name-camel-case
sweep-from-cheng[bot] Oct 29, 2023
838e851
Merge main into sweep/unify-json-name-camel-case
sweep-from-cheng[bot] Oct 29, 2023
f491ee1
Merge main into sweep/unify-json-name-camel-case
sweep-from-cheng[bot] Nov 14, 2023
4ce3986
Merge main into sweep/unify-json-name-camel-case
sweep-from-cheng[bot] Nov 22, 2023
b38fa06
Merge main into sweep/unify-json-name-camel-case
sweep-from-cheng[bot] Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/email_addresses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
class EmailAddress(sdk.python.entities.Entity):

resource = '/email_addresses/'
json_name = 'email_address'
json_name = 'emailAddress'

id = Property(int)
email_address = Property(str)
Expand All @@ -14,7 +14,7 @@ class EmailAddress(sdk.python.entities.Entity):
class EmailAddresses(sdk.python.entities.Resource):

entity_class = EmailAddress
json_name = 'email_addresses'
json_name = 'emailAddresses'


email_addresses = EmailAddresses()
2 changes: 1 addition & 1 deletion python/job_comments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class JobComment(sdk.python.entities.Entity):

resource = '/job_comments/'
json_name = 'job_comment'
json_name = 'jobComment'

id = Property(int)
file = Property(File)
Expand Down
2 changes: 1 addition & 1 deletion python/production_comments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class ProductionComment(sdk.python.entities.Entity):

resource = '/production_comments/'
json_name = 'production_comment'
json_name = 'productionComment'

id = Property(int)
file = Property(File)
Expand Down
2 changes: 1 addition & 1 deletion python/quote_items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class QuoteItem(sdk.python.entities.Entity):

resource = '/quote_items'
json_name = 'quote_item'
json_name = 'quoteItems'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be quoteItem instead of quoteItems

Copy link
Contributor Author

@sweep-from-cheng sweep-from-cheng bot Sep 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


id = Property(int)
type = Property(int)
Expand Down
Loading