Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added case insensitive options for sorting and filtering #1

Closed
wants to merge 2 commits into from

Conversation

mercmobily
Copy link
Owner

Added case insensitive options

@kriszyp
Copy link

kriszyp commented Jul 30, 2014

Adding better support for case insensitivity sounds good. The concern I have about this particular approach, is that I am hesitant to make queries be more context-sensitive. Generally, I think a query should fully and explicitly specify what matches and doesn't match, and with this approach a query behaves differently based on store configuration. And this also would make it difficult to have queries with mixed behavior (some properties case sensitive, some note).

For sorting, I think it would be quite reasonable to simply add another property to the sort objects that would specify case sensitivity.

For filtering, I would like to make the query building capable of handling this. Currently the Memory store should support {property: /^aNyCaSe$/i}. Of course, we have incomplete support for this, since presumably the Request may serialize this poorly for the query parameter.

@mercmobily
Copy link
Owner Author

This is now old... The way queries are made is completely changed.

@mercmobily mercmobily closed this Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants