Destroy PerfectScrollbar object and clear reference to HTMLElement af…

…ter component destroy
mercs600 · Oct 12, 2018 · 64985bf · 64985bf
1 parent 4d28296
commit 64985bf
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/src/Scrollbar.js b/src/Scrollbar.js
@@ -26,11 +26,20 @@ export default {
   updated () {
     this.update()
   },
+  beforeDestroy () {
+    this.destroy()
+  },
   methods: {
     update () {
       if (this.ps) {
         this.ps.update()
       }
+    },
+    destroy () {
+      if (this.ps) {
+        this.ps.destroy()
+        this.ps = null
+      }
     }
   },
   render (h) {

diff --git a/test/unit/Scrollbar.spec.js b/test/unit/Scrollbar.spec.js
@@ -19,4 +19,21 @@ describe('Scrollbar.vue', () => {
     })
     expect(wrapper.find('.ps').classes('ps--active-y')).to.be.false
   })
+
+  it('this.ps should be null after destroy', () => {
+    const wrapper = shallowMount(Scrollbar, {
+      attachToDocument: true
+    })
+    wrapper.destroy()
+    expect(wrapper.vm.ps).to.be.null
+  })
+
+  it('Component should remove reference do HTMLElement after destroy', () => {
+    const wrapper = shallowMount(Scrollbar, {
+      attachToDocument: true
+    })
+    let psObject = wrapper.vm.ps
+    wrapper.destroy()
+    expect(psObject.element).to.be.null
+  })
 })