Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use fragments #14

Merged
merged 3 commits into from
Dec 4, 2018
Merged

use fragments #14

merged 3 commits into from
Dec 4, 2018

Conversation

mercuriete
Copy link
Owner

@mercuriete mercuriete commented Dec 3, 2018 •
edited
Loading

Use Fragments instead of Activity

  • Closes use fragments #13
  • Move BPMCalculatorActivity to MainActivity and BPMCalculatorFragment
  • Make use of AndroidInjector for fragments
  • Add custom scopes but dont use it yet
  • Update dependencies

@mercuriete mercuriete force-pushed the 13-use-fragments branch 2 times, most recently from 4e65ec6 to 2806565 Compare December 4, 2018 17:13
@mercuriete mercuriete force-pushed the 13-use-fragments branch 2 times, most recently from 8588615 to a0cc392 Compare December 4, 2018 17:32
Use Fragments instead of Activity
5f0172c 
* Closes #13
* Move BPMCalculatorActivity to MainActivity and BPMCalculatorFragment
* Make use of AndroidInjector for fragments
@mercuriete mercuriete merged commit eb6714a into master Dec 4, 2018
@mercuriete mercuriete deleted the 13-use-fragments branch December 4, 2018 18:00
@mercuriete mercuriete mentioned this pull request Dec 4, 2018
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mercuriete