Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add parameters to defineResolvers in refresh #39

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

codeflyer
Copy link
Collaborator

pass missing lruGatewayCache on schema refresh.

Copy link
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were the tests not failing?

@codeflyer
Copy link
Collaborator Author

Why were the tests not failing?

to fail the missing of the factory param it was required a specific case that wasn't covered. A subscription on a gateway after a schema refresh.
I've added the test.

The lruGatewayResolvers instead is allowed to be null then if not passed it just don't use the cache. The test are passing in mercurius as well, if it's removed from the context.

A possible solution to test it can be to add the lruGatewayResolvers created to the gateway object. And set a spy on the function. WDYT?

Copy link
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codeflyer codeflyer merged commit a586d4f into main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants