Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(loaders): enhance loaders documentation #332

Merged
merged 4 commits into from
Oct 20, 2020

Conversation

PacoDu
Copy link
Contributor

@PacoDu PacoDu commented Oct 19, 2020

I had difficulties finding loaders documentation in the new website, a search query leads to the federation documentation about the __resolveReference loader.
I think it deserves its own section in the sidebar.

docs/loaders.md Outdated Show resolved Hide resolved
docs/federation.md Outdated Show resolved Hide resolved
docs/api/options.md Show resolved Hide resolved
PacoDu and others added 2 commits October 20, 2020 10:24
Co-authored-by: Pablo Sáez <pablosaez1995@gmail.com>
Co-authored-by: Pablo Sáez <pablosaez1995@gmail.com>
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PacoDu
Copy link
Contributor Author

PacoDu commented Oct 20, 2020

I think this is good to go, I've applied every modifications @PabloSzx suggested, thanks ;)

@mcollina mcollina merged commit eef7f08 into mercurius-js:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants