New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/graphiql plugins #892 #893
Feat/graphiql plugins #892 #893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
```javascript | ||
// examples/graphiql-plugin | ||
node ./index.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this isn't JS code (use sh for formatting properly) and you can omit "./"
|
||
```javascript | ||
app.get('/graphiql/samplePlugin.js', (req, reply) => { | ||
reply.sendFile('samplePlugin.js') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method on the reply comes from fastify/static, doesn't it? I wouldn't make the assumption that people know. either use a different method or make it more explicit where it's coming from
Co-authored-by: Simone Busoli <simone.busoli@gmail.com>
@simoneb can this land? I'd like to ship a release soon. |
good to go 👌 |
Allow injection of
graphiql
plugins in the configuration of amercurius
server:Closes #892