Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Docker image and Yarn version increment #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sonntag-philipp
Copy link

Greetings 馃憢

hope you guys are open for PRs on this project, but I thought this addition would be really useful. In short what I did is:

  • Added Dockerfile so we can build an image of the project
  • Added nginx config for the image so the image can be hosted in production environments
  • Incremented the yarn version so it will install dependencies even faster
  • Added packageManager property to the package.json to leverage corepack
  • Added automatic script to publish the image using GitHub actions. They are free for FOSS, so I think this is really nice anyway :D For this to work, MercurJS will need an own Docker account.

You can find the published image under "flypsi/mercur-vendor-starter" on Docker Hub. Hope you find this addition helpful :)

@sonntag-philipp
Copy link
Author

@agnwoj99 Sorry for the mention. I am just not sure if anyone sees this :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant