Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: exported target is broken #224

Closed
ael-code opened this issue May 22, 2018 · 1 comment
Closed

cmake: exported target is broken #224

ael-code opened this issue May 22, 2018 · 1 comment

Comments

@ael-code
Copy link

I'm experiencing an issue with an old cmake version (2.8.12.2).

The installation of exported target generates the ${INSTALL_PREFIX}/share/mercury/mercury-targets.cmake. Turns out that the na target has a wrong INTERFACE_INCLUDE_DIRECTORIES property. Looking at the generated mercury-targets.cmake code:

# Create imported target na
add_library(na SHARED IMPORTED)

set_target_properties(na PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "mercury_util;/opt/adafs/build_deps/lib/libbmi.so;/opt/adafs/build_deps/lib/libcci.so;/opt/adafs/build_deps/lib/libfabric.so"
)

The problem is that ${_IMPORT_PREFIX} is empty. Thus the na target ends up having /include as include directory, that is obviously wrong.

Probably this is related to this issue that I've found https://cmake.org/Bug/view.php?id=15258

@soumagne soumagne added this to the mercury-1.0.0 milestone May 25, 2018
@soumagne
Copy link
Member

Thanks for reporting the problem, it should be fine now.

@soumagne soumagne added the fixed label Oct 2, 2018
range3 pushed a commit to range3/GekkoFS that referenced this issue Apr 27, 2021
on centos the cmake 3 binary is called `cmake3`. In the compile script
we try to use the most recent version of cmake that is available on the
system.

This will allow to prevent this mercury installation issue:
mercury-hpc/mercury#224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants