NA CCI: Added error handling when cci_connect() fails #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
na_cci_addr_lookup()
is eventually called fromHG_Addr_lookup()
, the functioncci_connect()
can return an error which is currently not handled. As a result, clients receiveHG_SUCCESS
when callingHG_Addr_lookup()
although it has failed. This patch returns the appropriate error message for two cases: (1)cci_connect()
timed out, or (2) other errors.We faced this situation, while using CCI with the verbs plugin, when many clients called
HG_Addr_lookup()
to the same servers, essentially overwhelming the server to respond in time. The following error message was produced on the client side, withHG_Addr_lookup()
returningHG_SUCCESS
:Note, that
cci_connect()
can be given an optional timeout value (currently set toNULL
inna_cci_addr_lookup()
, i.e., wait forever according to documentation), which is not used incci_connect()
.