fix potential NPE before mock check.

mercyblitz · Nov 12, 2019 · 8be7726 · 8be7726
1 parent b133782
commit 8be7726
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/...g/dubbo-config-api/src/main/java/org/apache/dubbo/config/utils/ConfigValidationUtils.java b/...g/dubbo-config-api/src/main/java/org/apache/dubbo/config/utils/ConfigValidationUtils.java
@@ -490,12 +490,14 @@ public static void validateMethodConfig(MethodConfig config) {
         checkMethodName("name", config.getName());
 
         String mock = config.getMock();
-        if (mock.startsWith(RETURN_PREFIX) || mock.startsWith(THROW_PREFIX + " ")) {
-            checkLength(MOCK_KEY, mock);
-        } else if (mock.startsWith(FAIL_PREFIX) || mock.startsWith(FORCE_PREFIX)) {
-            checkNameHasSymbol(MOCK_KEY, mock);
-        } else {
-            checkName(MOCK_KEY, mock);
+        if (StringUtils.isNotEmpty(mock)) {
+            if (mock.startsWith(RETURN_PREFIX) || mock.startsWith(THROW_PREFIX + " ")) {
+                checkLength(MOCK_KEY, mock);
+            } else if (mock.startsWith(FAIL_PREFIX) || mock.startsWith(FORCE_PREFIX)) {
+                checkNameHasSymbol(MOCK_KEY, mock);
+            } else {
+                checkName(MOCK_KEY, mock);
+            }
         }
     }