New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add team assignment to request_review
action
#574
Conversation
request_review
actionrequest_review
action
Sorry, I don't understand what the OR failure is. |
Its because you didn't add an entry to changelog.rst , for new |
code looks good but it would be really helpful if you can try to do some test locally just to make sure that this feature does actually work. |
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 104 104
Lines 2345 2348 +3
Branches 413 415 +2
=======================================
+ Hits 2175 2178 +3
Misses 152 152
Partials 18 18
Continue to review full report at Codecov.
|
Will do! |
request_review
actionrequest_review
action
I tested this as well and it is working great. 馃帀 I updated the changelog and I think it's good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 馃帀
馃帀 This PR is included in version 2.3.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
馃憢 This PR adds support for a
teams
option on therequest_review
action which will assign GitHub teams like thereviewers
option does.I added tests which are passing, but I'm not sure about any other way to test since it's a marketplace app.
Closes #430