Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add team assignment to request_review action #574

Merged
merged 3 commits into from Aug 7, 2021

Conversation

bbugh
Copy link
Contributor

@bbugh bbugh commented Aug 4, 2021

馃憢 This PR adds support for a teams option on the request_review action which will assign GitHub teams like the reviewers option does.

I added tests which are passing, but I'm not sure about any other way to test since it's a marketplace app.

Closes #430

@bbugh bbugh changed the title Add team support to request_review action feat: Add team support to request_review action Aug 5, 2021
@bbugh
Copy link
Contributor Author

bbugh commented Aug 5, 2021

Sorry, I don't understand what the OR failure is.

@shine2lay
Copy link
Member

Sorry, I don't understand what the OR failure is.

Its because you didn't add an entry to changelog.rst , for new feat & fix , we keep track of changes in the changelog since we do continuous release

@shine2lay
Copy link
Member

code looks good but it would be really helpful if you can try to do some test locally just to make sure that this feature does actually work.
Here is a guide to deploying locally https://mergeable.readthedocs.io/en/latest/deployment.html

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #574 (e6c978f) into master (2838241) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         104      104           
  Lines        2345     2348    +3     
  Branches      413      415    +2     
=======================================
+ Hits         2175     2178    +3     
  Misses        152      152           
  Partials       18       18           
Impacted Files Coverage 螖
lib/github/api.js 93.03% <酶> (酶)
lib/actions/request_review.js 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2838241...e6c978f. Read the comment docs.

@bbugh
Copy link
Contributor Author

bbugh commented Aug 5, 2021

Will do!

@bbugh bbugh changed the title feat: Add team support to request_review action feat: Add team assignment to request_review action Aug 6, 2021
@bbugh
Copy link
Contributor Author

bbugh commented Aug 6, 2021

I tested this as well and it is working great. 馃帀

I updated the changelog and I think it's good to go.

Copy link
Member

@shine2lay shine2lay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃帀

@shine2lay shine2lay merged commit 5b93bca into mergeability:master Aug 7, 2021
@github-actions
Copy link

github-actions bot commented Aug 7, 2021

馃帀 This PR is included in version 2.3.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible request review for a GitHub Team?
2 participants