Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo "were ran" vs "were run" typo #737

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

AlberTajuelo
Copy link
Contributor

This PR is based on this previous PR (#689). If this PR is merged, #689 could be closed because this contains the previous PR.

Following the same blog post.

This PR includes:

  • Typo fix
  • Documentation fix
  • Test E2E fix to match the typo.

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (c6d0d68) to head (906d62f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #737   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files         110      110           
  Lines        2878     2878           
  Branches      577      577           
=======================================
  Hits         2674     2674           
  Misses        185      185           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlberTajuelo AlberTajuelo changed the title fix: were ran typo chore: fix typo "were ran" vs "were run" typo Mar 3, 2024
@AlberTajuelo
Copy link
Contributor Author

Hey @jusx @shine2lay,

Could we get this merged and close PR #689 ?? Thanks!

@shine2lay shine2lay merged commit 375def2 into mergeability:master Mar 12, 2024
4 checks passed
Copy link

🎉 This PR is included in version 2.17.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants