fix: Docker image not working #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #753 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 110 110
Lines 2878 2881 +3
Branches 578 581 +3
=======================================
+ Hits 2674 2677 +3
Misses 185 185
Partials 19 19 ☔ View full report in Codecov by Sentry. |
Ch4s3r
commented
Jun 10, 2024
| @@ -1,5 +1,7 @@ | |||
| CHANGELOG | |||
| ===================================== | |||
| | June 10, 2024: fix: Docker image not working `#753 <https://github.com/mergeability/mergeable/pull/753>`_ | |||
| | June 10, 2024: feat: publish multi arch docker image to dockerhub `#751 <https://github.com/mergeability/mergeable/pull/751>`_ | |||
There was a problem hiding this comment.
Added changelog entry for previous PR
|
@shine2lay @jusx please have a look :) |
shine2lay
approved these changes
Jun 10, 2024
|
🎉 This PR is included in version 2.18.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
Dockerfilewas using nodejs version 16 and not building at all.This PR adds a new setup created with
docker init.It uses node 18 now as stated in the
package.json.These versions need to be kept in sync, so updating the nodejs version must also happen in the
Dockerfile.Executing the new docker image works: