Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: :boolean for :orm #349

Closed
wants to merge 1 commit into from

Conversation

burmashave
Copy link

To silence 'thor' deprecation notices.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.098% when pulling cf4d15c on burmashave:thor-deprecation into ea936eb on merit-gem:master.

@tute
Copy link
Member

tute commented Jul 22, 2020

Thanks for your PR! I missed the other files in my branch (#346 (comment)).

It used to be a string though: it would be mongo or activerecord. But we don't support that option anymore, would you try deleting all the hooks please, and see if the warning is fixed? Thanks!

@tute
Copy link
Member

tute commented Jul 22, 2020

Please add to the commit message th context you described well in the issue, #346 (comment), so that it stays in the repository, aiding future debugging. Thank you again!

@burmashave
Copy link
Author

Ah, okay. Closing this; issued a separate PR with hooks removed.

@burmashave burmashave closed this Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants