fix(parser): fixed computed property names - added missing "parseMemb…

…erOrUpdateExpression"
meriyah · May 14, 2019 · 01add5d · 01add5d
1 parent 1a887fd
commit 01add5d
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 6 deletions.
diff --git a/src/parser.ts b/src/parser.ts
@@ -3996,6 +3996,8 @@ export function parseObjectLiteralOrPattern(
                 ? parseArrayExpressionOrPattern(parser, context, /* skipInitializer */ 0, type)
                 : parseObjectLiteralOrPattern(parser, context, /* skipInitializer */ 0, type);
 
+            value = parseMemberOrUpdateExpression(parser, context, value, /* isNewExpression */ 0);
+
             destructible = parser.destructible;
 
             parser.assignable =
@@ -4010,14 +4012,12 @@ export function parseObjectLiteralOrPattern(
                 ? DestructuringKind.Assignable
                 : DestructuringKind.NotDestructible) | parser.assignable;
           }
-        } else {
-          if (parser.token !== Token.LeftParen) {
-            report(parser, Errors.InvalidComputedPropName);
-          }
-
+        } else if (parser.token === Token.LeftParen) {
           state |= PropertyKind.Method;
           value = parseMethodDefinition(parser, context, state);
-          destructible |= parser.assignable | DestructuringKind.NotDestructible;
+          destructible = DestructuringKind.NotDestructible;
+        } else {
+          report(parser, Errors.InvalidComputedPropName);
         }
       } else if (parser.token === Token.Multiply) {
         consume(parser, context | Context.AllowRegExp, Token.Multiply);

diff --git a/test/parser/expressions/object.ts b/test/parser/expressions/object.ts
@@ -11158,6 +11158,47 @@ describe('Expressions - Object', () => {
         ]
       }
     ],
+    [
+      '({ [a]: {} [a] })',
+      Context.None,
+      {
+        type: 'Program',
+        sourceType: 'script',
+        body: [
+          {
+            type: 'ExpressionStatement',
+            expression: {
+              type: 'ObjectExpression',
+              properties: [
+                {
+                  type: 'Property',
+                  key: {
+                    type: 'Identifier',
+                    name: 'a'
+                  },
+                  value: {
+                    type: 'MemberExpression',
+                    object: {
+                      type: 'ObjectExpression',
+                      properties: []
+                    },
+                    computed: true,
+                    property: {
+                      type: 'Identifier',
+                      name: 'a'
+                    }
+                  },
+                  kind: 'init',
+                  computed: true,
+                  method: false,
+                  shorthand: false
+                }
+              ]
+            }
+          }
+        ]
+      }
+    ],
     [
       'x = {15:b}',
       Context.None,