fix(parser): removed some useless code

meriyah · Jul 5, 2019 · 597eaf2 · 597eaf2
1 parent 2e3ff8d
commit 597eaf2
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 28 deletions.
diff --git a/src/common.ts b/src/common.ts
@@ -412,27 +412,19 @@ export function finishNode<T extends Node>(
 
 
   /** @internal */
-  export function isEqualTagName(lhs: any, rhs: any): boolean {
-    if (lhs.type !== rhs.type) {
-        return false;
-    }
-
-    if (lhs.type === 'JSXIdentifier') {
-        return lhs.name === rhs.name;
-    }
-
-    if (lhs.type === 'JSXNamespacedName') {
-      return lhs.namespace + ':' + lhs.name === rhs.namespace + ':' + rhs.name;
-    }
-
-    if (lhs.type === 'JSXMemberExpression') {
-      (
-        isEqualTagName(lhs.object, rhs.object) + '.' +
-        isEqualTagName(lhs.property, rhs.property)
-    ) === (
-      isEqualTagName(lhs.object, rhs.object) + '.' +
-        isEqualTagName(lhs.property, rhs.property)
-  )
-    }
-    return true;
+  export function isEqualTagName(elementName: any): any {
+    switch (elementName.type) {
+      case 'JSXIdentifier':
+          return elementName.name;
+      case 'JSXNamespacedName':
+          return elementName.namespace + ':' + elementName.name;
+      case 'JSXMemberExpression':
+          return (
+            isEqualTagName(elementName.object) + '.' +
+            isEqualTagName(elementName.property)
+          );
+          /* istanbul ignore next */
+      default:
+          // ignore
+  }
 }
diff --git a/src/parser.ts b/src/parser.ts
@@ -8024,9 +8024,9 @@ function parseJSXRootElementOrFragment(
       parser.linePos,
       parser.colPos
     );
-    if (!isEqualTagName(closingElement.name, openingElement.name)) {
-      report(parser, Errors.Unexpected);
-    }
+    const open = isEqualTagName(openingElement.name);
+    const close = isEqualTagName(closingElement.name);
+    if (open !== close) report(parser, Errors.Unexpected);
   }
 
   return finishNode(parser, context, start, line, column, {
@@ -8244,6 +8244,7 @@ function parseJSXElementName(
   column: number
 ): ESTree.JSXIdentifier | ESTree.JSXMemberExpression {
   scanJSXIdentifier(parser);
+
   let name: any = parseJSXIdentifier(parser, context, start, line, column);
 
   // Namespace

diff --git a/test/parser/miscellaneous/jsx.ts b/test/parser/miscellaneous/jsx.ts
@@ -34,7 +34,11 @@ describe('Miscellaneous - JSX', () => {
     ['<f><g/></ff>;', Context.OptionsJSX],
     // ['<:path />', Context.OptionsJSX],
     ['<path></svg:path>', Context.OptionsJSX],
-    // ['<foo.bar></foo.baz>', Context.OptionsJSX],
+    ['<foo.bar></foo.baz>', Context.OptionsJSX],
+    ['<chinese:alladinfoo.bar></foo.baz>', Context.OptionsJSX],
+    ['<foo:bar></foo.baz>', Context.OptionsJSX],
+    ['<foo:bar.baz></foo.baz:bar>', Context.OptionsJSX],
+    ['<foo.bar></foo.baz>', Context.OptionsJSX],
     ['var x = <div>one</div> /* intervening comment */ <div>two</div>;', Context.OptionsJSX],
     ['<tag className=></tag>', Context.OptionsJSX],
     //['<tag ... ></tag>', Context.OptionsJSX],
@@ -78,7 +82,7 @@ describe('Miscellaneous - JSX', () => {
     ['var x = <div>one</div>, <div>two</div>;', Context.OptionsJSX]
   ]);
 
-  pass('Expressions - Additive (pass)', [
+  pass('Miscellaneous - JSX (pass)', [
     [
       `<!--ccc-->`,
       Context.OptionsJSX,