fix(parser): Fixes #5

meriyah · May 15, 2019 · 7805610 · 7805610
1 parent f48b486
commit 7805610
Show file tree

Hide file tree

Showing 3 changed files with 126 additions and 8 deletions.
diff --git a/src/parser.ts b/src/parser.ts
@@ -711,12 +711,14 @@ export function parseAsyncArrowOrAsyncFunctionDeclaration(
   /** ArrowFunction[In, Yield, Await]:
    *    ArrowParameters[?Yield, ?Await][no LineTerminator here]=>ConciseBody[?In]
    */
-  expr =
-    parser.token === Token.LeftParen
-      ? parseAsyncArrowOrCallExpression(parser, context & ~Context.DisallowInContext, expr, 1, asyncNewLine as 0 | 1)
-      : parser.token === Token.Arrow
-      ? parseArrowFunctionExpression(parser, context, [expr], /* isAsync */ 0)
-      : expr;
+  if (parser.token === Token.LeftParen)
+    expr = parseAsyncArrowOrCallExpression(parser, context & ~Context.DisallowInContext, expr, 1, asyncNewLine as
+      | 0
+      | 1);
+  else if (parser.token === Token.Arrow) expr = parseArrowFunctionExpression(parser, context, [expr], /* isAsync */ 0);
+  else {
+    parser.assignable = AssignmentKind.Assignable;
+  }
 
   /** MemberExpression :
    *   1. PrimaryExpression
@@ -3158,8 +3160,8 @@ export function parseArrayExpressionOrPattern(
       } else if (parser.token & Token.IsPatternStart) {
         left =
           parser.token === Token.LeftBrace
-            ? parseObjectLiteralOrPattern(parser, context, skipInitializer, type)
-            : parseArrayExpressionOrPattern(parser, context, skipInitializer, type);
+            ? parseObjectLiteralOrPattern(parser, context, /* skipInitializer*/ 0, type)
+            : parseArrayExpressionOrPattern(parser, context, /* skipInitializer*/ 0, type);
 
         destructible |= parser.destructible;
 

diff --git a/test/parser/declarations/functions.ts b/test/parser/declarations/functions.ts
@@ -1034,6 +1034,71 @@ describe('Declarations - Function', () => {
         sourceType: 'script'
       }
     ],
+    [
+      'function* a( [ {  x  =  y  }  =  a ] )  { }',
+      Context.None,
+      {
+        type: 'Program',
+        sourceType: 'script',
+        body: [
+          {
+            type: 'FunctionDeclaration',
+            params: [
+              {
+                type: 'ArrayPattern',
+                elements: [
+                  {
+                    type: 'AssignmentPattern',
+                    left: {
+                      type: 'ObjectPattern',
+                      properties: [
+                        {
+                          type: 'Property',
+                          kind: 'init',
+                          key: {
+                            type: 'Identifier',
+                            name: 'x'
+                          },
+                          computed: false,
+                          value: {
+                            type: 'AssignmentPattern',
+                            left: {
+                              type: 'Identifier',
+                              name: 'x'
+                            },
+                            right: {
+                              type: 'Identifier',
+                              name: 'y'
+                            }
+                          },
+                          method: false,
+                          shorthand: true
+                        }
+                      ]
+                    },
+                    right: {
+                      type: 'Identifier',
+                      name: 'a'
+                    }
+                  }
+                ]
+              }
+            ],
+            body: {
+              type: 'BlockStatement',
+              body: []
+            },
+            async: false,
+            generator: true,
+            expression: false,
+            id: {
+              type: 'Identifier',
+              name: 'a'
+            }
+          }
+        ]
+      }
+    ],
     [
       'function a( a = b  ) {} n => {  "use strict"; }',
       Context.None,

diff --git a/test/parser/statements/if.ts b/test/parser/statements/if.ts
@@ -35,6 +35,57 @@ describe('Statements - None', () => {
   ]);
 
   pass('Statements - If (pass)', [
+    [
+      'if (async === void 0) { async = false; }',
+      Context.OptionsWebCompat,
+      {
+        type: 'Program',
+        sourceType: 'script',
+        body: [
+          {
+            type: 'IfStatement',
+            test: {
+              type: 'BinaryExpression',
+              left: {
+                type: 'Identifier',
+                name: 'async'
+              },
+              right: {
+                type: 'UnaryExpression',
+                operator: 'void',
+                argument: {
+                  type: 'Literal',
+                  value: 0
+                },
+                prefix: true
+              },
+              operator: '==='
+            },
+            consequent: {
+              type: 'BlockStatement',
+              body: [
+                {
+                  type: 'ExpressionStatement',
+                  expression: {
+                    type: 'AssignmentExpression',
+                    left: {
+                      type: 'Identifier',
+                      name: 'async'
+                    },
+                    operator: '=',
+                    right: {
+                      type: 'Literal',
+                      value: false
+                    }
+                  }
+                }
+              ]
+            },
+            alternate: null
+          }
+        ]
+      }
+    ],
     [
       'if (a) b()',
       Context.OptionsWebCompat,