fix(parser): directive is only for statement consisting entirely of a…

… string literal closes #99
meriyah · Oct 6, 2020 · 8186dc1 · 8186dc1
1 parent 7a7fc76
commit 8186dc1
Show file tree

Hide file tree

Showing 2 changed files with 75 additions and 2 deletions.
diff --git a/src/parser.ts b/src/parser.ts
@@ -1174,7 +1174,7 @@ export function parseDirective(
     matchOrInsertSemicolon(parser, context | Context.AllowRegExp);
   }
 
-  return context & Context.OptionsDirectives
+  return context & Context.OptionsDirectives && expression.type === 'Literal' && typeof expression.value === 'string'
     ? finishNode(parser, context, start, line, column, {
         type: 'ExpressionStatement',
         expression,

diff --git a/test/parser/expressions/in.ts b/test/parser/expressions/in.ts
@@ -147,8 +147,81 @@ describe('Expressions -In', () => {
                 name: '__proto'
               },
               operator: 'in'
+            }
+          }
+        ]
+      }
+    ],
+    [
+      '"use strict"',
+      Context.OptionsRaw | Context.OptionsDirectives,
+      {
+        type: 'Program',
+        sourceType: 'script',
+        body: [
+          {
+            type: 'ExpressionStatement',
+            expression: {
+              type: 'Literal',
+              value: 'use strict',
+              raw: '"use strict"'
+            },
+            directive: 'use strict'
+          }
+        ]
+      }
+    ],
+    [
+      '"any-string"',
+      Context.OptionsRaw | Context.OptionsDirectives,
+      {
+        type: 'Program',
+        sourceType: 'script',
+        body: [
+          {
+            type: 'ExpressionStatement',
+            expression: {
+              type: 'Literal',
+              value: 'any-string',
+              raw: '"any-string"'
             },
-            directive: 'valueOf'
+            directive: 'any-string'
+          }
+        ]
+      }
+    ],
+    [
+      '"any-string"',
+      Context.OptionsRaw,
+      {
+        type: 'Program',
+        sourceType: 'script',
+        body: [
+          {
+            type: 'ExpressionStatement',
+            expression: {
+              type: 'Literal',
+              value: 'any-string',
+              raw: '"any-string"'
+            }
+          }
+        ]
+      }
+    ],
+    [
+      '123',
+      Context.OptionsRaw | Context.OptionsDirectives,
+      {
+        type: 'Program',
+        sourceType: 'script',
+        body: [
+          {
+            type: 'ExpressionStatement',
+            expression: {
+              type: 'Literal',
+              value: 123,
+              raw: '123'
+            }
           }
         ]
       }