fix: dot property should allow escaped keyword in strict mode

closes #224
meriyah · Sep 10, 2022 · efaa535 · efaa535
1 parent 427233e
commit efaa535
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 8 deletions.
diff --git a/src/lexer/identifier.ts b/src/lexer/identifier.ts
@@ -85,13 +85,20 @@ export function scanIdentifierSlowCase(
     }
 
     if (context & Context.Strict) {
-      return token === Token.StaticKeyword
-        ? Token.EscapedFutureReserved
-        : (token & Token.FutureReserved) === Token.FutureReserved
-        ? Token.EscapedFutureReserved
-        : (token & Token.Reserved) === Token.Reserved
-        ? Token.EscapedReserved
-        : Token.AnyIdentifier;
+      if (token === Token.StaticKeyword) {
+        return Token.EscapedFutureReserved;
+      }
+      if ((token & Token.FutureReserved) === Token.FutureReserved) {
+        return Token.EscapedFutureReserved;
+      }
+      if ((token & Token.Reserved) === Token.Reserved) {
+        if (context & Context.AllowEscapedKeyword && (context & Context.InGlobal) === 0) {
+          return token;
+        } else {
+          return Token.EscapedReserved;
+        }
+      }
+      return Token.AnyIdentifier;
     }
     if (
       context & Context.AllowEscapedKeyword &&

diff --git a/test/parser/miscellaneous/escaped-keyword.ts b/test/parser/miscellaneous/escaped-keyword.ts
@@ -89,14 +89,24 @@ describe('Miscellaneous - Escaped keywords', () => {
     `async function a() {
       \\u0061sync
       p => {}
-    }`
+    }`,
+    `obj.bre\\u0061k = 42;`,
+    `for (\\u0061sync of [7]);`
   ]) {
     it(`${arg}`, () => {
       t.doesNotThrow(() => {
         parseSource(`${arg}`, undefined, Context.None);
       });
     });
   }
+
+  for (const arg of [`obj.bre\\u0061k = 42;`, `for (\\u0061sync of [7]);`]) {
+    it(`${arg}`, () => {
+      t.doesNotThrow(() => {
+        parseSource(`${arg}`, undefined, Context.Strict | Context.Module);
+      });
+    });
+  }
   //
   fail('Miscellaneous - Escaped identifiers (failures)', [
     ['(x === n\\u0075ll);', Context.None],