Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for(x of~y); is incorrectly rejected #226

Closed
bakkot opened this issue Sep 30, 2022 · 1 comment · Fixed by #227
Closed

for(x of~y); is incorrectly rejected #226

bakkot opened this issue Sep 30, 2022 · 1 comment · Fixed by #227
Assignees
@3cp

Comments

@bakkot
Copy link

bakkot commented Sep 30, 2022

Found this with a fuzzer, so feel free to ignore; this didn't come up in real code.

Issue is as the title says: for(x of~y); is a legal program, though not one you'd normally encounter, and meriyah rejects it.
@3cp 3cp self-assigned this Sep 30, 2022
@3cp
Copy link
Member

3cp commented Sep 30, 2022

Should be easy to fix. The problem is the tokenizer didn't separate of~, as for(x of ~y); works fine right now.

3cp added a commit that referenced this issue Oct 1, 2022
@3cp
fix(parser): ~ (0x7e) is valid stop for Identifier or Keyword
d702ebd 
closes #226
@3cp 3cp mentioned this issue Oct 1, 2022
Merged
@3cp 3cp closed this as completed in #227 Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3cp 3cp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(parser): ~ (0x7e) is a valid stop for Identifier or Keyword meriyah/meriyah
2 participants
@3cp @bakkot