Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: support loc flag when using onComment #95

Closed
davidbonnet opened this issue Sep 20, 2020 · 2 comments · Fixed by #119
Closed

Feature: support loc flag when using onComment #95

davidbonnet opened this issue Sep 20, 2020 · 2 comments · Fixed by #119

Comments

@davidbonnet
Copy link
Contributor

Setting { loc: true, onComment: [] } should set the loc property on generated comment objects.
@KFlash
Copy link
Contributor

KFlash commented Sep 20, 2020

Sounds like a good idea. Do you want to do a PR ?

@KFlash
Copy link
Contributor

KFlash commented Sep 21, 2020

@aladdin-add Maybe add this to next release?

3cp added a commit that referenced this issue Oct 25, 2020
@3cp
feat: support loc flag for onComment and onToken
b61015f 
Also fixed onToken, the "start/end" should respect ranges flag, not loc flag.

closes #95
@3cp 3cp mentioned this issue Oct 25, 2020
Merged
3cp added a commit that referenced this issue Oct 25, 2020
@3cp
feat: support loc flag for onComment and onToken
464caba 
Also fixed onToken, the "start/end" should respect ranges flag, not loc flag.

closes #95
3cp added a commit that referenced this issue Oct 25, 2020
@3cp
feat: support loc flag for onComment and onToken
287b77c 
Also fixed onToken, the "start/end" should respect ranges flag, not loc flag.

closes #95
@3cp 3cp closed this as completed in #119 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support loc flag for onComment and onToken meriyah/meriyah
2 participants
@davidbonnet @KFlash