feat(parser): Add support for class static initialization block #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cp
reviewed
May 9, 2022
|
@aladdin-add could you have a look too? |
aladdin-add
approved these changes
May 13, 2022
| import { Context } from '../../../src/common'; | ||
| import { pass, fail } from '../../test-utils'; | ||
|
|
||
| describe('Next - Class static initialization block', () => { |
There was a problem hiding this comment.
good to have a few more tests. afaict, the test262 has many failing cases. tc39/test262@afe217b
we can try to add the test262 at some point, but surely it should be another PR, and won't block merging this one.
|
There are works to be done before we can ship it. I tried first few test262, it didn't work as expected. |
|
I don't have time to improve this for now. Just released v4.3.0 to include this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #194 and one point from #214.
Proposal: https://github.com/tc39/proposal-class-static-block
MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Class_static_initialization_blocks
V8 examples: https://v8.dev/features/class-static-initializer-blocks
ESTree: https://github.com/estree/estree/blob/master/es2022.md#staticblock