-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update TypeScript to v5 #270
Conversation
I have seen weird ts v5.5 typing issue in other projects. |
Maybe this solution is acceptable? microsoft/TypeScript#9998 (comment) |
I think it's a ts bug, it assumes our |
But the same typing error also pops up with ts v4. The fix is ugly |
Had a read of the ts github issue. It sounds like ts would not address this issue anytime soon. If you have time to apply the |
I am also very confused why we didn't have this issue with ts v4 and v3 before. |
# Conflicts: # src/parser.ts
d953f5f
to
8879c01
Compare
Done. |
No description provided.