Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GondelReactComponent expects JSON script tags with wrong MIME type #80

Open
dhardtke opened this issue May 27, 2021 · 0 comments
Open

GondelReactComponent expects JSON script tags with wrong MIME type #80

dhardtke opened this issue May 27, 2021 · 0 comments

Comments

@dhardtke
Copy link

dhardtke commented May 27, 2021 •
edited
Loading

According to https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types (and various other sources) the MIME type for json is application/json yet

gondel/packages/plugins/react/src/GondelReactComponent.tsx

Line 116 in 5cf2151

const configScript = ctx.querySelector("script[type='text/json']");
expects text/json.

When we changed the MIME type in our project the JSON was no longer found. I propose we change the lookup to preferably look for application/json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhardtke