Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gondle examples work again #94

Closed
ernscht opened this issue Jul 18, 2023 · 2 comments
Closed

Make gondle examples work again #94

ernscht opened this issue Jul 18, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@ernscht
Copy link
Member

ernscht commented Jul 18, 2023

Issue:
The examples no longer work in CodeSandbox environments.
Current Error message: "Invalid Host Header"

Current solution:
The examples are pulled directly from the GitHub repo (CodeSandbox pulls from master branch).
However, Code-Sandbox is constantly being modified, so these examples are currently no longer working.

Wanted
Maybe we'll get this solution working again.
Also ideas are welcome for alternative solutions.
@ernscht ernscht added the help wanted Extra attention is needed label Jul 18, 2023
stefanibus pushed a commit to stefanibus/gondel that referenced this issue Oct 18, 2023
fix: invalid host header issue on codesandbox
95220c1 
solves Issue merkle-open#94 (The examples no longer work in CodeSandbox environments.)

We need to add the allowedhosts-flag to devServer-settings for webpack.config:

devServer-config to solve "Invalid Host header Issue" on CodeSandBox:

codesandbox/codesandbox-client#3392 and

https://stackoverflow.com/a/43647767 and
  https://codesandbox.io/docs/learn/repositories/task#configuring-task-ports

https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md#firewall

https://webpack.js.org/configuration/dev-server/#devserverallowedhosts

firewall: false, // failed while testing

disableHostCheck: true, // failed while testing

allowedHosts: This flag finally solved it
@stefanibus stefanibus mentioned this issue Oct 18, 2023
Merged
stefanibus pushed a commit to stefanibus/gondel that referenced this issue Oct 20, 2023
fix: invalid host header issue on codesandbox
a9b09ee 
solves Issue merkle-open#94 (The examples no longer work in CodeSandbox environments.)

We need to add the allowedhosts-flag to devServer-settings for webpack.config:

devServer-config to solve "Invalid Host header Issue" on CodeSandBox:

codesandbox/codesandbox-client#3392 and

https://stackoverflow.com/a/43647767 and
  https://codesandbox.io/docs/learn/repositories/task#configuring-task-ports

https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md#firewall

https://webpack.js.org/configuration/dev-server/#devserverallowedhosts

firewall: false, // failed while testing

disableHostCheck: true, // failed while testing

allowedHosts: This flag finally solved it
@ernscht
Copy link
Member Author

ernscht commented Oct 23, 2023

This fix solved most of the issues. Most examples work again, thanks a lot @stefanibus

There remain two other problems:

module not found:

tsconfig.json

@ernscht
Copy link
Member Author

ernscht commented Oct 27, 2023

All examples now work again. Great. Thank you.

@ernscht ernscht closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ernscht