Skip to content
This repository has been archived by the owner on Jul 13, 2021. It is now read-only.

Cannot unregister unregistered terrific component #1

Closed
janbiasi opened this issue Jul 7, 2017 · 0 comments
Closed

Cannot unregister unregistered terrific component #1

janbiasi opened this issue Jul 7, 2017 · 0 comments
Assignees
Milestone

Comments

@janbiasi
Copy link
Contributor

janbiasi commented Jul 7, 2017

I'm submitting a ...


[ ] Regression (behavior that used to work and stopped working in a new release)
[x] Bug report 
[ ] Feature request
[ ] Documentation issue or request

Current behavior

image

Expected behavior

It should not try unregister an unregistered component - or at least not throw an error. Beside that, the error should also show in which process the failure happened (e.g. unregisterComponent(...)).

Minimal reproduction of the problem with instructions

Call TerrificBridge.unregisterComponent(...) in the components componentWillUnmount hook without registering it in the componentDidMount hook.

What is the motivation / use case for changing the behavior?

Better debugging and preventing fatal errors.

Please tell us about your environment


TerrificBridge version: 1.2.5


Browser:
- [x] Every Browser
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: 6.2 
- Platform: Mac 

Others:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants