Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split code formatting from naming convention #8

Closed
Regaddi opened this issue Feb 8, 2018 · 2 comments
Closed

Split code formatting from naming convention #8

Regaddi opened this issue Feb 8, 2018 · 2 comments

Comments

@Regaddi
Copy link

Regaddi commented Feb 8, 2018

Hey,

it'd be super practical, if we'd split the code formatting config from the BEM naming config.
We don't use this package right now in e.g. React projects, where we use component based style loading and therefore don't need BEM.
However it would be great, if we included a default code formatting configuration, that provides default configurations for our CSS files.
I'd suggest to split this package into two separate ones: one for BEM and the other for basic CSS code formatting.

@ernscht
Copy link
Member

ernscht commented Feb 8, 2018

Hey Chris
This is just a stylelint plugin for the bem-linting part. it's an addition to other css linting rules which are defined elsewhere. (e.g https://github.com/namics/frontend-defaults/blob/master/codequality/stylelint/.stylelintrc)

I do not understand where we could split here.

@Regaddi
Copy link
Author

Regaddi commented Feb 14, 2018

I totally missed out, that the general linting configuration is at frontend-defaults.
Everything's good 😄

@Regaddi Regaddi closed this as completed Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants