Merge pull request #132 from merkle-open/feature/replace-node-sass-wi…

…th-sass feat(scss-config-webpack-plugin): Replace deprecated Node Sass with Sass
merkle-open · Jun 6, 2023 · 2504140 · 2504140
2 parents 02e3683 + 9810b23
commit 2504140
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/packages/scss-config-webpack-plugin/config/development.config.js b/packages/scss-config-webpack-plugin/config/development.config.js
@@ -46,7 +46,7 @@ exports = module.exports = (options) => ({
 					{
 						loader: require.resolve('sass-loader'),
 						options: {
-							implementation: require('node-sass'),
+							implementation: require('sass'),
 						},
 					},
 				],
@@ -99,7 +99,7 @@ exports = module.exports = (options) => ({
 					{
 						loader: require.resolve('sass-loader'),
 						options: {
-							implementation: require('node-sass'),
+							implementation: require('sass'),
 						},
 					},
 				],

diff --git a/packages/scss-config-webpack-plugin/config/production.config.js b/packages/scss-config-webpack-plugin/config/production.config.js
@@ -61,7 +61,7 @@ exports = module.exports = (options) => ({
 					{
 						loader: require.resolve('sass-loader'),
 						options: {
-							implementation: require('node-sass'),
+							implementation: require('sass'),
 							sourceMap: true,
 						},
 					},
@@ -122,7 +122,7 @@ exports = module.exports = (options) => ({
 					{
 						loader: require.resolve('sass-loader'),
 						options: {
-							implementation: require('node-sass'),
+							implementation: require('sass'),
 							sourceMap: true,
 						},
 					},

diff --git a/packages/scss-config-webpack-plugin/package.json b/packages/scss-config-webpack-plugin/package.json
@@ -30,13 +30,13 @@
     "css-loader": "^5.2.4",
     "iconfont-webpack-plugin": "^5.0.1",
     "mini-css-extract-plugin": "^1.5.0",
-    "node-sass": "^5.0.0",
     "optimize-css-assets-webpack-plugin": "^5.0.4",
     "postcss": "^8.2.10",
     "postcss-flexbugs-fixes": "^5.0.2",
     "postcss-loader": "^4.2.0",
     "postcss-safe-parser": "^5.0.2",
     "resolve-url-loader": "^3.1.2",
+    "sass": "1.49.0",
     "sass-loader": "^10.1.1",
     "style-loader": "^2.0.0"
   },

diff --git a/packages/scss-config-webpack-plugin/test/__snapshots__/ScssConfigWebpackPlugin.test.js.snap b/packages/scss-config-webpack-plugin/test/__snapshots__/ScssConfigWebpackPlugin.test.js.snap
@@ -4,15 +4,16 @@ exports[`ScssConfigWebpackPlugin inside webpack context should avoid common flex
 ".foo {
   display: flex;
   flex-direction: row;
-  flex: 1 1; }
-"
+  flex: 1 1;
+}"
 `;
 
 exports[`ScssConfigWebpackPlugin inside webpack context should avoid common flexbox bugs in older browsers in development mode with sourcemap 1`] = `
 ".foo {
   display: flex;
   flex-direction: row;
-  flex: 1 1; }"
+  flex: 1 1;
+}"
 `;
 
 exports[`ScssConfigWebpackPlugin inside webpack context should avoid common flexbox bugs in older browsers in production mode 1`] = `".foo{display:flex;flex-direction:row;flex:1 1}"`;