Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Remove the include.always variable from the image(obj) function #23

Closed
AlexanderLyNL opened this issue Jul 11, 2018 · 3 comments

Comments

@AlexanderLyNL
Copy link

Hi Merlise,

Would it be possible to remove the variables that are "include.always" from the plotting output:

  • plot(obj) [in particular, the Inclusion Probabilities plot]
  • image(obj)
    I think that this might be sensible. By removing the include.always variables, there's more space to display the effects of the variables that are of interest, and it might save some space for memory as well.

Cheers,
Alexander

@merliseclyde
Copy link
Owner

Yes; there is a subset option for image to specify which variables to include, so in principle we can bootstrap off of that rather easily. plot.bas does not have that option, but a similar fix should be straightforward there.

I'll probably need to add an option to save the indices of the variables that are always included as part of the output to simplify identifying them later. (needed as well for the flat prior and shrinkage in issue #22 )

@AlexanderLyNL AlexanderLyNL changed the title [Enhancement] Remove the include.always variable from the image(obj) [Enhancement] Remove the include.always variable from the image(obj) function Jul 11, 2018
@merliseclyde
Copy link
Owner

This is added to image.bas now in the master branch, using option drop.include.always=TRUE (default). Feedback welcome!

@merliseclyde
Copy link
Owner

Update: switched drop.always.included to be FALSE by default in image.bas so that defaults agree with images in Coursera course.

added subset=NULL and drop.always.included=FALSE to plot.bas so that a subset of probabilities may be shown/dropped or variables that are always forced in may be excluded. Default settings agree with what is in Coursera course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants