Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken insert overlay for iOS 16 #42

Merged
merged 2 commits into from May 27, 2023

Conversation

vincentneo
Copy link
Contributor

iOS 16's MKMapView

insertOverlay(tileServerOverlay, at: 0, level: .aboveLabels)

appears to be broken. Often, the overlay will overlap above other overlays even when insert at index 0.
Refer to merlos/iOS-Open-GPX-Tracker#232 and merlos/iOS-Open-GPX-Tracker@ec4edbd#comments for more info.

@vincentneo
Copy link
Contributor Author

Confirmed on iOS 16.1 (non-beta) that issue still exists, via Open GPX Tracker.

Issue only pertains to building for iOS 16.x SDKs / Xcode 14.x. It does not impact App Store versions or apps built for iOS 15.x SDK running on iOS 16.x.

@xoif
Copy link

xoif commented Nov 30, 2022

In our app I noticed the following since iOS16:

  • MKPolyline and MKPolygon are not displayed anymore. Sometimes they reappear/blink shortly while changing the zoom level
  • Same holds true for our WMS Layers (which are basically just custom MKTileOverlays)
  • No such issues on iOS15
  • No such issues if I don't call mapView.useCache(mapCache)
  • Copy/Pasting the fixed "useCache" from this Mergerequest, into an own extension MKMapView, fixes the issue for our WMS Layers, but MKPolyline and MKPolygon still don't work.

@vincentneo
Copy link
Contributor Author

vincentneo commented Nov 30, 2022

@xoif, please have a look at merlos/iOS-Open-GPX-Tracker@a18801c. This additional change might fix at least MKPolyline (never tested MKPolygon, so I don't know).

@xoif
Copy link

xoif commented Dec 1, 2022

@vincentneo thanks for the fast response. I just applied your additional changes and added my Polylines and Polygones with addOverlayOnTop. I can confirm that both Polylines and Polygones are working again.

@merlos merlos merged commit 371d428 into merlos:master May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants