Trial/activity type #113
Merged
Trial/activity type #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in current segment distance label. Fix #109
vincentneo
reviewed
Aug 6, 2019
There was a problem hiding this comment.
I think that it would be better practice to add in documentation for the codes before merge. Will try to add them bit by bit as time permits.
I didn't do so at first, as I didn't mean to make the branch as a pull request. (Though testing it gave quite inconclusive results)
The descriptions look real good though, as they provide more information for the average user.
Also, CLActivityType+Info was really inspired/mirrored from GPXTileServer's style.
|
Good point about the documentation, I forgot about it. I will be able to do some tests of this feature next week as I´ll be traveling. |
|
@vincentneo doc is now included 👍 |
|
Looking good now! Will merge. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vincentneo
Although it is a bit advanced for a regular user I am fine with exposing the activity type to the user.
I changed some of the activity types and added a short description for each mode to try to ease the selection.
BTW, I really like the way you used
CLActivityType+Info.swiftto display the options.